Skip to content

Fix crash on missing env var in dashboard link formatting#7729

Merged
hendrikmakait merged 3 commits into
dask:mainfrom
milesgranger:7724-log-on-dashboard-link-fmt-error
Apr 14, 2023
Merged

Fix crash on missing env var in dashboard link formatting#7729
hendrikmakait merged 3 commits into
dask:mainfrom
milesgranger:7724-log-on-dashboard-link-fmt-error

Conversation

@milesgranger

@milesgranger milesgranger commented Mar 31, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #7724

  • Tests added / passed
  • Passes pre-commit run --all-files

@milesgranger milesgranger requested a review from fjetter as a code owner March 31, 2023 08:27
jacobtomlinson
jacobtomlinson reviewed Mar 31, 2023
View reviewed changes

@jacobtomlinson jacobtomlinson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for jumping on this so quickly.

Comment thread distributed/scheduler.py Outdated
@jacobtomlinson jacobtomlinson mentioned this pull request Mar 31, 2023
Closed
@github-actions

github-actions Bot commented Mar 31, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       26 files  +       24         26 suites  +24   14h 37m 46s ⏱️ + 13h 46m 53s
  3 549 tests +       52    3 437 ✔️ +       52     106 💤  -        6  6 ❌ +6 
44 897 runs  +41 389  42 650 ✔️ +39 265  2 240 💤 +2 117  7 ❌ +7 

For more details on these failures, see this check.

Results for commit 491fef6. ± Comparison against base commit e1944ec.

This pull request removes 1 and adds 53 tests. Note that renamed tests count towards both. 
distributed.tests.test_scheduler ‑ test_multiple_listeners

distributed.cli.tests.test_dask_scheduler
distributed.cli.tests.test_dask_scheduler ‑ test_signal_handling[15]
distributed.cli.tests.test_dask_scheduler ‑ test_signal_handling[2]
distributed.cli.tests.test_dask_ssh
distributed.cli.tests.test_dask_worker ‑ test_signal_handling[15---nanny]
distributed.cli.tests.test_dask_worker ‑ test_signal_handling[15---no-nanny]
distributed.cli.tests.test_dask_worker ‑ test_signal_handling[2---nanny]
distributed.cli.tests.test_dask_worker ‑ test_signal_handling[2---no-nanny]
distributed.dashboard.tests.test_components
distributed.dashboard.tests.test_scheduler_bokeh
…

♻️ This comment has been updated with latest results.

@jacobtomlinson

jacobtomlinson commented Mar 31, 2023

Copy link
Copy Markdown
Member

Awesome thanks @milesgranger. Looks like black is unhappy now though.

@milesgranger milesgranger force-pushed the 7724-log-on-dashboard-link-fmt-error branch from d4b988b to cea9ec6 Compare April 3, 2023 09:34
@jrbourbeau jrbourbeau mentioned this pull request Apr 5, 2023
Closed
4 tasks
@milesgranger milesgranger force-pushed the 7724-log-on-dashboard-link-fmt-error branch from cea9ec6 to 491fef6 Compare April 11, 2023 17:26
@milesgranger

milesgranger commented Apr 14, 2023

Copy link
Copy Markdown
Contributor Author

Ready for a review @jrbourbeau @j-bennet @hendrikmakait
Thanks in advance. :)

hendrikmakait
hendrikmakait approved these changes Apr 14, 2023
View reviewed changes

@hendrikmakait hendrikmakait left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @milesgranger! CI failures appear to be unrelated.

@hendrikmakait hendrikmakait merged commit 717905f into dask:main Apr 14, 2023
@milesgranger milesgranger deleted the 7724-log-on-dashboard-link-fmt-error branch April 14, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hendrikmakait hendrikmakait hendrikmakait approved these changes
@fjetter fjetter Awaiting requested review from fjetter fjetter is a code owner
@jacobtomlinson jacobtomlinson Awaiting requested review from jacobtomlinson

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Scheduler crashes in SSHCluster in 2023.3.2 but not in 2023.3.1

3 participants

@milesgranger @jacobtomlinson @hendrikmakait